Skip to content

Commit

Permalink
Upgrade Node.js from 8.4.0 to 8.9.1 LTS (#175)
Browse files Browse the repository at this point in the history
Node.js 8.9.1 released. It's LTS(Long Term Support) version.

ISSUE=#174
  • Loading branch information
romandev committed Nov 10, 2017
1 parent 9c31788 commit 6c08eee
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
12 changes: 6 additions & 6 deletions bootstrap/common/sync_third_party.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@

function sync_node() {
local target_path="./third_party/node"
local base_url="https://nodejs.org/dist/v8.4.0"
local base_url="https://nodejs.org/dist/v8.9.1"

case $(get_platform_name) in
windows_x86) local target_url="/node-v8.4.0-win-x86.zip" ;;
windows_x86_64) local target_url="/node-v8.4.0-win-x64.zip" ;;
linux_x86) local target_url="/node-v8.4.0-linux-x86.tar.gz" ;;
linux_x86_64) local target_url="/node-v8.4.0-linux-x64.tar.gz" ;;
darwin_x86_64) local target_url="/node-v8.4.0-darwin-x64.tar.gz" ;;
windows_x86) local target_url="/node-v8.9.1-win-x86.zip" ;;
windows_x86_64) local target_url="/node-v8.9.1-win-x64.zip" ;;
linux_x86) local target_url="/node-v8.9.1-linux-x86.tar.gz" ;;
linux_x86_64) local target_url="/node-v8.9.1-linux-x64.tar.gz" ;;
darwin_x86_64) local target_url="/node-v8.9.1-darwin-x64.tar.gz" ;;
esac

sync_third_party $base_url$target_url $target_path
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"electron-rebuild": "^1.6.0",
"jest": "^21.2.1",
"mkdirp": "^0.5.1",
"node-addon-api": "^0.6.3",
"node-addon-api": "^1.0.0",
"node-gyp": "^3.6.2",
"nunjucks": "^3.0.1",
"ts-jest": "^21.1.0",
Expand Down
3 changes: 2 additions & 1 deletion template/bacardi_cpp.njk
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,11 @@
#include "{{interface.idl_dir_name}}/{{interface.name | snakecase}}_bridge.h"
{% endfor %}

void Init(Napi::Env env, Napi::Object exports, Napi::Object module) {
Napi::Object Init(Napi::Env env, Napi::Object exports) {
{% for interface in interfaces %}
{{interface.name}}Bridge::Init(env, exports);
{% endfor %}
return exports;
}

NODE_API_MODULE(bacardi, Init);
Expand Down

0 comments on commit 6c08eee

Please sign in to comment.