Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some lint errors in client directory using lint:fix #540

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

sapzape
Copy link
Contributor

@sapzape sapzape commented Nov 24, 2017

Performed the lint:fix command. That fixes some lint errors in
client/ directory.

ISSUE=#533

@sapzape
Copy link
Contributor Author

sapzape commented Nov 24, 2017

@romandev PTAL

@romandev
Copy link
Member

lgtm;

I modified your commit description as follows:

  • DO NOT USE I did something blah blah. If possible, it's better to use imperative mood.
  • Each line should be < 72 byte.
  • Need a blank line your commit description and ISSUE=#533

@romandev romandev changed the title Fixed some lint errors in client area using 'lint:fix' Fixed some lint errors in client directory using 'lint:fix' Nov 24, 2017
@romandev romandev changed the title Fixed some lint errors in client directory using 'lint:fix' Fixed some lint errors in client directory using lint:fix Nov 24, 2017
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit 90d649c into lunchclass:master Nov 24, 2017
@sapzape
Copy link
Contributor Author

sapzape commented Nov 24, 2017

@romandev Thank you. I will note!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants