Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Truncate proxy entries #27

Merged
merged 1 commit into from
Nov 15, 2024
Merged

fix: Truncate proxy entries #27

merged 1 commit into from
Nov 15, 2024

Conversation

Wolmin
Copy link

@Wolmin Wolmin commented Nov 14, 2024

Description and Related Issue(s)

This PR fixes a bug where profile names appeared as contract proxies instead of the profile names.
Before:
image

After:
image

Proposed Changes

Added a truncation for proxy text. Also added a check for enabled universal profiles before fetching

Breaking or Incompatible Changes

[Describe any breaking or incompatible changes introduced by this pull request. Specify how users might need to modify their code or configurations to accommodate these changes.]

Additional Information

[Include any additional information, context, or screenshots that may be helpful for reviewers.]

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

@Wolmin Wolmin added the bug Something isn't working label Nov 14, 2024
@Wolmin Wolmin requested review from richtera and mxmar November 14, 2024 12:34
@Wolmin Wolmin self-assigned this Nov 14, 2024
@Wolmin Wolmin merged commit 574a668 into lukso Nov 15, 2024
14 of 17 checks passed
@Wolmin Wolmin deleted the fix/universalprofileinit-desc branch November 15, 2024 11:19
Wolmin added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants