feat: Algolia Removal #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
approved these changes
Oct 10, 2024
| return { | ||
| type: 'universal_profile', | ||
| name: hitAsUp.hasProfileName ? hitAsUp.LSP3Profile.name : null, | ||
| address: hit.objectID, | ||
| name: hitAsUp.name !== '' ? hitAsUp.name : null, |
There was a problem hiding this comment.
Considering that UPs may have names to be absolutely anything if those are set outside of our mobile app or extension should we trim the name to be sure it doesn't contain only whitespace characters? 🤔
Or is it already done and here we get the trimmed version?
There was a problem hiding this comment.
Thats a good idea, but let me check and confirm
JeneaVranceanu
approved these changes
Oct 10, 2024
richtera
approved these changes
Oct 10, 2024
Wolmin
added a commit
that referenced
this pull request
Jan 15, 2025
* Initial graph client impl * Fetching logic * Generalize types * Validate graph env * Trim name Signed-off-by: Wolmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
This PR removes Algolia as a dependency from the project and replaces it with a graph indexer for searching profiles.
Breaking or Incompatible Changes
See Checklist for new ENVs
Additional Information
[Include any additional information, context, or screenshots that may be helpful for reviewers.]
Checklist for PR author