Fix: Algolia optimization #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esanim
approved these changes
Jan 17, 2024
|
You prob. need to update snapshots for tests to pass. |
Hugoo
reviewed
Jan 17, 2024
There was a problem hiding this comment.
i think the props are confusing
You used to use address as a string, now address is an object with props you will not use at all like is_verified and so on.
I suggest to keep this as lean and clean as possible by keeping the getUniversalProfile() function as simple as possible.
I suggest to:
- do an early return: if address.is_contract -> don't even call that function. No need to pass all the mess down the other functions
- Or if 1. doesnt not work, to add a "isContract" arg for the getUniversalProfile - so it is clear this things only need a has (address) and a bool and you don't move all these usesless props all around which makes things confusing imo
|
smtgh like that 
|
Wolmin
force-pushed
the
fix/algolia-optimization
branch
from
6d35271 to
0dfc045
Compare
Wolmin
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
This PR adjusts calls for algolia proxy, to optimize resources usage
Checklist for PR author