Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SP-1776 : interpret LF as cumulative and use appropriately #437

Merged
merged 1 commit into from
Jan 13, 2025
Merged

SP-1776 : interpret LF as cumulative and use appropriately #437

merged 1 commit into from
Jan 13, 2025

Conversation

rhiannonlynne
Copy link
Member

No description provided.

@rhiannonlynne
Copy link
Member Author

See Issue #410
There was also a discussion on slack or email at one point (lost now, unfortunately). But the crowding calculation was intended to run on a differential luminosity function, and what we have in the data files is a cumulative LF, so this adds that correction.

yoachim
yoachim approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@rhiannonlynne rhiannonlynne merged commit 15fcf12 into main Jan 13, 2025
6 of 7 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/SP-1776 branch January 13, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoachim yoachim yoachim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhiannonlynne @yoachim