DM-41640: Propagate calib_psf_used information to stars catalog in CalibrateImageTask #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's easier to debug when the tests use the same names as the code: sources->psf_stars
There should be 5 calib-worthy S/N>10 stars, not 4! The SN~10 source has a less precise centroid, so we need to increase the astrometry check by a bit.
erykoff
approved these changes
Jan 11, 2024
Propagate psf and aperture correction fields from psf_stars to stars, without overwriting anything else in stars. Some of this code was lifted from `CalibrateTask.copyIcSourceFields`.
parejkoj
force-pushed
the
tickets/DM-41640
branch
from
477bc03 to
1bc1a49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.