DM-41512: Add check for no good sources in finalizeCharacterization #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-41512
branch
from
134cb1a to
e885677
Compare
laurenam
force-pushed
the
tickets/DM-41512
branch
2 times, most recently
from
b8e9ae3 to
57ce0ca
Compare
erykoff
approved these changes
Nov 2, 2023
| @@ -598,6 +609,10 @@ def compute_psf_and_ap_corr_map(self, visit, detector, exposure, src, isolated_s | |||
| """ | |||
| # Apply source selector (s/n, flags, etc.) | |||
| good_src = self.source_selector.selectSources(src) | |||
| if sum(good_src.selected) < 1: | |||
There was a problem hiding this comment.
I would do a check == 0 here as well.
laurenam
force-pushed
the
tickets/DM-41512
branch
from
57ce0ca to
2834191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.