Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40955: LATISS psf stamp size is incorrect for the large PSFs #855

Closed
wants to merge 1 commit into from
Closed

DM-40955: LATISS psf stamp size is incorrect for the large PSFs #855

wants to merge 1 commit into from

Conversation

laurenam
Copy link
Contributor

No description provided.

@laurenam
Import psfex to finalize_characterization
56073b0 
The kernel and stamp sizes for PSF modelling of LATISS data are
required to be quite large, and piff will likely not scale well,
so we need the option to retarget to psfex to avoid long runtimes.
@laurenam laurenam requested a review from erykoff November 1, 2023 04:23
erykoff
erykoff approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is necessary; a question is whether this was always wrong and we should be doing the import in the config override file?

@laurenam
Copy link
Contributor Author

laurenam commented Nov 1, 2023

Excellent point! I just asked at standup and all agreed it should go in the config. I’ll do that and check all is working before merging (and then this PR will just get closed).

@laurenam laurenam closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurenam @erykoff