DM-40387: CalibrateImage improvements #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isullivan
approved these changes
Oct 24, 2023
| @@ -463,10 +465,23 @@ def _compute_psf(self, exposure, guess_psf=True): | |||
| cell_set : `lsst.afw.math.SpatialCellSet` | |||
| PSF candidates returned by the psf determiner. | |||
| """ | |||
| self.log.info("First pass detection with Guassian PSF FWHM=%s", self.config.install_simple_psf.fwhm) | |||
| def log_psf(msg): | |||
There was a problem hiding this comment.
Just a preference, but I would like to see exposure (or psf) passed in explicitly, along with background.
There was a problem hiding this comment.
It's a closure, so it already has access to all local variables.
parejkoj
force-pushed
the
tickets/DM-40387
branch
2 times, most recently
from
a1cc1e1 to
620206f
Compare
It now says whether the CRs were fixed or not.
We need to run repair with keepCRs=False (the default) and re-measure in order to not have CRs included in the final output.
Some summary information about the fitted PSF is informative about fit convergence during CR repair.
In order to deblend out fainter sources, we probably want to detect deeper than we need for the final star catalog (which is still S/N>10). Whether this change is strictly necessary needs to be investigated further.
parejkoj
force-pushed
the
tickets/DM-40387
branch
from
620206f to
055584b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.