Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47796: Deprecate some coadd-processing connections and configs. #1012

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

TallJimbo
Copy link
Member

No description provided.

Copy link
Contributor

@fred3m fred3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you got everything here. I left one suggestion to also deprecate the multi-part of the task name, since it only runs multiband. Other than that this LGTM.

@@ -213,12 +229,17 @@ def run(self, coadd, mergedDetections, idFactory):
return Struct(measureCatalog=sources)


class DeblendCoaddSourcesMultiTask(DeblendCoaddSourcesBaseTask):
class DeblendCoaddSourcesMultiTask(PipelineTask):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to rename this to DeblendCoaddSourcesTask now that there is no DeblendCoaddSouresSingleTask?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth the additional disruption right now (though if we did rename it, I'd want to get Sources out of the names of all of the coadd-processing tasks, too).

@TallJimbo TallJimbo merged commit 7f202ee into main Dec 2, 2024
2 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-47796 branch December 2, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants