DM-38120: Add VIGNETTED bit mask #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Nov 11, 2024
include/lsst/afw/image/Mask.h
Outdated
| @@ -72,6 +72,10 @@ using MaskPlaneDict = std::map<std::string, int>; | |||
| * - `INTRP` This pixel has been interpolated over @note should be called `INTERPOLATED` | |||
| * - `SAT` This pixel is saturated and has bloomed @note should be called `SATURATED` | |||
| * - `SUSPECT` This pixel is untrustworthy, and you may wish to discard any Source containing it | |||
| * - `NO_DATA` This pixel could not have received flux, e.g. fully vignetted, no available flux from coadd | |||
There was a problem hiding this comment.
Suggested change
| * - `NO_DATA` This pixel could not have received flux, e.g. fully vignetted, no available flux from coadd | |
| * - `NO_DATA` This pixel received little or no flux, e.g. fully vignetted, no available flux from coadd |
It's usually useful to start setting this mask plane before the flux level drops all the way to zero.
include/lsst/afw/image/Mask.h
Outdated
| @@ -72,6 +72,10 @@ using MaskPlaneDict = std::map<std::string, int>; | |||
| * - `INTRP` This pixel has been interpolated over @note should be called `INTERPOLATED` | |||
| * - `SAT` This pixel is saturated and has bloomed @note should be called `SATURATED` | |||
| * - `SUSPECT` This pixel is untrustworthy, and you may wish to discard any Source containing it | |||
| * - `NO_DATA` This pixel could not have received flux, e.g. fully vignetted, no available flux from coadd | |||
| * input exposures. | |||
| * - `VIGNETTED` This pixel is in a vignetted region, and has received less than 75% of the expected | |||
There was a problem hiding this comment.
I do think it'd be better to leave the actual number to ISR configuration.
Also add doc note for NO_DATA, which was missing (though nobody reads this docstring anyway).
parejkoj
force-pushed
the
tickets/DM-38120
branch
from
41b242d to
e4e75dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.