Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42012: Add a unittest for MaskedImageFitsReader #719

Merged
merged 2 commits into from
Dec 6, 2023
Merged

DM-42012: Add a unittest for MaskedImageFitsReader #719

merged 2 commits into from
Dec 6, 2023

Conversation

arunkannawadi
Copy link
Member

No description provided.

@arunkannawadi arunkannawadi force-pushed the tickets/DM-42012 branch 3 times, most recently from 3aa8c2b to 097f8ec Compare December 5, 2023 16:33
@arunkannawadi arunkannawadi marked this pull request as ready for review December 5, 2023 16:35
@arunkannawadi arunkannawadi requested a review from timj December 5, 2023 16:35
timj
timj approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. The obs_base test is the important one for butler.

@arunkannawadi arunkannawadi force-pushed the tickets/DM-42012 branch 4 times, most recently from 8102346 to cc6bab3 Compare December 6, 2023 20:46
@arunkannawadi arunkannawadi merged commit ab0ec9d into main Dec 6, 2023
2 checks passed
@arunkannawadi arunkannawadi deleted the tickets/DM-42012 branch December 6, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunkannawadi @timj