Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45302: ISR section #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion isr.tex
Original file line number Diff line number Diff line change
@@ -1,6 +1,38 @@
\section{Instrument Signature Removal}
\label{sec:isr}

Raw images from charge-coupled devices (CCDs) contain instrumental effects, such as dark currents, clocking artifacts or crosstalk between neighboring amplifiers, that can be removed in the data processing.
In the Rubin pipeline, this step is called Instrument Signature Removal (ISR) and is the first processing applied to a raw CCD exposure.
The package performing the ISR on an exposure, called \texttt{ip\_isr}, is detailed below in Sec. \ref{sec:ip_isr}: it is a critical package for Data Release Pipeline (DRP) used to process LSST images and requires calibration products produced and verified by \texttt{cp\_pipe} and \texttt{cp\_verify} respectively as described in Sec. \ref{sec:calib_pipe}.
In Sec. \ref{sec:isr:ampoffset}, we specifically describe the correction of amplifier offset in more details.

We note that we focus here on our approach to perform ISR on data from LSST cameras only (LSSTCam, ComCam and LATISS), although we also provide calibration pipelines for other cameras such as DECam and HSC (using a different ISR approach).

\subsection{ISR package}
\label{sec:ip_isr}

Exposures from LSST cameras are affected by instrumental effects, ranging from well-known CCD effects like dark currents or biases to effects more recently characterized like tree-rings (see \cite{park_properties_2017,park_tree_2020,esteves_photometry_2023} for more details on tree rings in LSSTCam) or the Brighter-Fatter effect as discussed in \cite{broughton_2023}. Correcting for these effects requires specific calibrations, which we refer to as calibration products. In LSST cameras, calibration products typically are a combined bias, a combined dark, a Photon Transfer Curve (PTC), a crosstalk matrix, a list of defects and a look-up table of non-linearity parameters.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dark currents and bias levels"?

The meaning of these calibration products and the details on the Rubin Observatory's ISR and calibration approach can be found in \url{https://sitcomtn-086.lsst.io/v/SITCOM-949/index.html}.
\begin{figure}[h!]
\centering
\includegraphics[scale=0.25]{isr_plots/instrumentmodel_isr.png}
\caption{Schematic of the instrument model for detector effects in LSST cameras which \texttt{isrTaskLSST} is based on at the time of publication. Diagram made by Eli Rykoff, more details about the model can be found in \url{https://sitcomtn-086.lsst.io/v/SITCOM-949/index.html}.}
\label{fig:isr_model}
\end{figure}

The \texttt{ip\_isr} package\footnote{\url{https://github.com/lsst/ip_isr}} contains the codes needed to remove instrument signatures in exposures from LSST cameras and to produce calibration products.
To inform our ISR approach, we first designed a model of the instrument, displayed in Fig. \ref{fig:isr_model}, based on our knowledge of the hardware and electronics. This model states the order in which the different known instrumental effects happen, from a photon hitting the CCD to the output ADC unit (ADU) signal.
In turn, \texttt{isrTaskLSST} in \texttt{ip\_isr} sequentially applies correction of these effects, typically by calling other \texttt{Tasks} (\textit{e.g.} overscan, crosstalk, etc.) also implemented in \texttt{ip\_isr}.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"These corrections are applied in the opposite order as their effects occur in the model, as we are attempting to remove the impact of those effects on the image."? I mostly want to qualify that sequentially operates in the opposite direction as how they're added in the model.






Overall, \texttt{isrTaskLSST} takes a \texttt{raw} CCD exposure, and calibration products if available, and outputs a \texttt{Struct} containing the input exposure, the \texttt{postISRCCD} output exposure as well as its binned version for easier display, the exposure before interpolation and statistics on the output exposure.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"containing the output exposure"? The input isn't returned.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And possibly "exposure without interpolation," as it should have all the other processing steps done.

\texttt{IsrTaskLSSTConfig} defines the configurations used in this \texttt{Task}, they are set by default to their expected value to perform ISR on a typical LSSTCam exposure. Configurations starting with \texttt{do} will typically correspond to an ISR step, they are turned on or off in the pipelines when producing the different calibration products.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Configuration parameters starting with [...]"

We have also developed \texttt{isrMockLSST} which simulates a raw exposure and corresponding calibration products and is used to test \texttt{isrTaskLSST}.


\subsection{Amplifier Offset Correction}
\label{sec:isr:ampoffset}
The amplifier offset correction (commonly referred to as amp-offset correction, or pattern continuity correction) runs as part of the instrument signature removal (ISR) process.
Expand All @@ -14,4 +46,13 @@ \subsection{Amplifier Offset Correction}
These amp-interface differences are stored in an amp-offset matrix; diagonal entries represent the number of neighboring amplifiers, and off-diagonal entries encode information about the associations between amplifiers.
A complementary interface matrix encodes directional information for these associations.
Using this information, a least-squares minimization is performed to determine the optimal pedestal value to be added or subtracted to each amp which would reduce the amp-offset between that amplifier and all of its neighboring amplifiers.
This method is generalized to support 2D amplifier geometries within a detector, as with LSSTCam, incorporating length-based weighting into the matrices to account for amplifiers that are not square.
This method is generalized to support 2D amplifier geometries within a detector, as with LSSTCam, incorporating length-based weighting into the matrices to account for amplifiers that are not square.

\subsection{Calibration pipelines}
\label{sec:calib_pipe}

The pipelines to build calibration products (\texttt{cp}) for the LSST cameras are defined in \texttt{cp\_pipe}\footnote{\url{https://github.com/lsst/cp\_pipe} and see documentation at \url{https://pipelines.lsst.io/modules/lsst.cp.pipe/constructing-calibrations.html}}.
They mainly set \texttt{isrTaskLSST} configurations needed for each calibration product. In some cases, they also specify whether to combine exposures (for bias or dark exposures for instance) and to bin exposures to support display.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a a sentence or two that the configurations for construction enable all corrections that happen in IsrTask up to but not including the application of the correction to be generated, and that the verify configuration enables everything up to and including the application of the correction being verified? It may be obvious, but I don't think it hurts to be clear.


Once calibration products are produced, they are ``verified'' using \texttt{cp\_verify} pipelines by checking they pass metrics defined in \url{https://dmtn-101.lsst.io/}. They then can be certified to be available in the \texttt{butler} and used to ISR an exposure.

Binary file added isr_plots/instrumentmodel_isr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
60 changes: 60 additions & 0 deletions local.bib
Original file line number Diff line number Diff line change
@@ -1,3 +1,63 @@
@misc{broughton_2023,
title={Mitigation of the Brighter-Fatter Effect in the LSST Camera},
author={Alex Broughton and Yousuke Utsumi and Andrés Plazas Malagón and Christopher Waters and Craig Lage and Adam Snyder and Andrew Rasmussen and Stuart Marshall and Jim Chiang and Simona Murgia and Aaron Roodman},
year={2023},
eprint={2312.03115},
archivePrefix={arXiv},
primaryClass={astro-ph.IM},
url={https://arxiv.org/abs/2312.03115},
}

@article{park_properties_2017,
title = {Properties of tree rings in {LSST} sensors},
volume = {12},
issn = {1748-0221},
url = {https://doi.org/10.1088/1748-0221/12/05/c05015},
doi = {10.1088/1748-0221/12/05/C05015},
language = {en},
number = {05},
urldate = {2022-09-28},
journal = {Journal of Instrumentation},
author = {Park, H. Y. and Nomerotski, A. and Tsybychev, D.},
month = may,
year = {2017},
note = {Publisher: IOP Publishing},
pages = {C05015--C05015},
file = {IOP Full Text PDF:/Users/ferte/Zotero/storage/35MKRS7T/Park et al. - 2017 - Properties of tree rings in LSST sensors.pdf:application/pdf},
}

@article{park_tree_2020,
title = {Tree rings in {Large} {Synoptic} {Survey} {Telescope} production sensors: its dependence on radius, wavelength, and back bias voltage},
volume = {6},
issn = {2329-4124, 2329-4221},
shorttitle = {Tree rings in {Large} {Synoptic} {Survey} {Telescope} production sensors},
url = {https://www.spiedigitallibrary.org/journals/Journal-of-Astronomical-Telescopes-Instruments-and-Systems/volume-6/issue-1/011005/Tree-rings-in-Large-Synoptic-Survey-Telescope-production-sensors/10.1117/1.JATIS.6.1.011005.full},
doi = {10.1117/1.JATIS.6.1.011005},
number = {1},
urldate = {2022-09-28},
journal = {Journal of Astronomical Telescopes, Instruments, and Systems},
author = {Park, Hye Yun and Karpov, Sergey and Nomerotski, Andrei and Tsybychev, Dmitri},
month = jan,
year = {2020},
note = {Publisher: SPIE},
pages = {011005},
file = {Full Text PDF:/Users/ferte/Zotero/storage/C8LG45AI/Park et al. - 2020 - Tree rings in Large Synoptic Survey Telescope prod.pdf:application/pdf;Snapshot:/Users/ferte/Zotero/storage/RPLIK243/1.JATIS.6.1.011005.html:text/html},
}

@misc{esteves_photometry_2023,
title = {Photometry, {Centroid} and {Point}-{Spread} {Function} {Measurements} in the {LSST} {Camera} {Focal} {Plane} {Using} {Artificial} {Stars}},
url = {http://arxiv.org/abs/2308.00919},
doi = {10.48550/arXiv.2308.00919},
urldate = {2023-08-22},
publisher = {arXiv},
author = {Esteves, Johnny H. and Utsumi, Yousuke and Snyder, Adam and Schutt, Theo and Broughton, Alex and Trbalic, Bahrudin and Mau, Sidney and Rasmussen, Andrew and Malagón, Andrés A. Plazas and Bradshaw, Andrew and Marshall, Stuart and Digel, Seth and Chiang, James and Soares-Santos, Marcelle and Roodman, Aaron},
month = aug,
year = {2023},
note = {arXiv:2308.00919 [astro-ph]},
keywords = {Astrophysics - Instrumentation and Methods for Astrophysics},
annote = {Comment: Submitted to PASP},
file = {arXiv Fulltext PDF:/Users/ferte/Zotero/storage/XNLA4XNX/Esteves et al. - 2023 - Photometry, Centroid and Point-Spread Function Mea.pdf:application/pdf;arXiv.org Snapshot:/Users/ferte/Zotero/storage/R7276A6P/2308.html:text/html},
}

@INPROCEEDINGS{2020ASPC..522..541J,
author = {{Jenness}, Tim},
Expand Down
Loading