fix: Get all the PRs in sorted by updatedAt (#229)

ls1intum · Jan 19, 2025 · ae17856 · ae17856
1 parent 6e4a006
commit ae17856
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/...ication-server/src/main/java/de/tum/cit/aet/helios/pullrequest/PullRequestRepository.java b/...ication-server/src/main/java/de/tum/cit/aet/helios/pullrequest/PullRequestRepository.java
@@ -18,7 +18,9 @@ Optional<PullRequest> findByRepositoryRepositoryIdAndHeadRefNameAndState(Long re
                                                                            String headRefName,
                                                                            Issue.State state);
 
-  List<PullRequest> findByRepositoryRepositoryId(Long repositoryId);
+  List<PullRequest> findAllByOrderByUpdatedAtDesc();
+
+  List<PullRequest> findByRepositoryRepositoryIdOrderByUpdatedAtDesc(Long repositoryId);
 
   Optional<PullRequest> findByRepositoryRepositoryIdAndNumber(Long repositoryId, Integer number);
 }
diff --git a/...pplication-server/src/main/java/de/tum/cit/aet/helios/pullrequest/PullRequestService.java b/...pplication-server/src/main/java/de/tum/cit/aet/helios/pullrequest/PullRequestService.java
@@ -17,7 +17,7 @@ public PullRequestService(PullRequestRepository pullRequestRepository) {
   }
 
   public List<PullRequestBaseInfoDto> getAllPullRequests() {
-    return pullRequestRepository.findAll().stream()
+    return pullRequestRepository.findAllByOrderByUpdatedAtDesc().stream()
         .map(PullRequestBaseInfoDto::fromPullRequest)
         .collect(Collectors.toList());
   }
@@ -27,7 +27,8 @@ public Optional<PullRequestInfoDto> getPullRequestById(Long id) {
   }
 
   public List<PullRequestInfoDto> getPullRequestByRepositoryId(Long repositoryId) {
-    return pullRequestRepository.findByRepositoryRepositoryId(repositoryId).stream()
+    return pullRequestRepository.findByRepositoryRepositoryIdOrderByUpdatedAtDesc(repositoryId)
+        .stream()
         .map(PullRequestInfoDto::fromPullRequest)
         .collect(Collectors.toList());
   }