Add interval Type #219
Open
Add interval Type #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, the only Travis build that failed appears to also be failing on master (cabal version issue) and is for the oldest GHC (7.6.3) being tested. |
|
Thanks for the PR. Yes, I am aware of the build issue with travis, and haven't looked into it too deeply yet. I will not hold that against you. :) |
|
this would be nice to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at adding an
IntervalADT to this library as per this conversation:#176
Let me know your thoughts or any changes you'd like to see. FYI I'm a bit unsure about the appropriate precision for the Interval's fields.
Although I'm testing against PostgreSQL 9.6.3 I appear to have run into this bug (or something similar):
https://www.postgresql.org/message-id/CAMWF=HS++N9-NKsh-o5QSymvp0Np-VB0GdWwAt4uie1h8ZdNTQ@mail.gmail.com
so the Interval builder splits microseconds back out into hours/minutes/seconds/microseconds to keep the numbers low.