Add handling of bags on class attributes to Item similar as it is on Room #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is intentional. But the room class initializer contains code to deepcopy instances of
Bag
from class attributes to instance variables. Which allows to defineand add items afterwards
My son was using this pattern to build items which can contain other items (for example a shelf).
Because the initializer of class
Item
is missing that code to copy bags, this did not work as expected, because there will be only one instance ofBag
for every item.I suggest to add the same handling of bags to class
Item
.