fix(backupbackingimage): encode URL for NFS backup target with options

ref: longhorn/longhorn 9702 Signed-off-by: James Lu <[email protected]>
longhorn · Oct 24, 2024 · c988d4f · c988d4f
1 parent ef7b22d
commit c988d4f
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/backupbackingimage/config.go b/backupbackingimage/config.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"net/url"
 	"path/filepath"
+	"strings"
 
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
@@ -117,7 +118,11 @@ func getBackingImageBlockPath() string {
 func EncodeBackupBackingImageURL(backingImageName, destURL string) string {
 	v := url.Values{}
 	v.Add("backingImage", backingImageName)
-	return destURL + "?" + v.Encode()
+	prefixChar := "?"
+	if strings.Contains(destURL, "?") {
+		prefixChar = "&"
+	}
+	return destURL + prefixChar + v.Encode()
 }
 
 func DecodeBackupBackingImageURL(backupURL string) (string, string, error) {