Standardize SSL settings #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
d48dbb5 to
1dacba8
Compare
edmocosta
commented
Mar 30, 2023
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
1dacba8 to
481994e
Compare
…ith deprecated configuration
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
481994e to
c0af983
Compare
edmocosta
changed the title
andsel
requested changes
Mar 31, 2023
|
|
||
| import static org.hamcrest.Matchers.*; |
There was a problem hiding this comment.
Avoid * import switch to explicit list
There was a problem hiding this comment.
same for the following import of such kind
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
f4c6175 to
b2a56ef
Compare
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
b2a56ef to
19e21ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Added the following SSL settings
ssl_enabled: Enable/disable SSLssl_client_authentication: Controls the server’s behavior in regard to requesting a certificate from client connectionsReviewed and deprecated the following SSL settings to comply with Logstash's naming convention
sslin favor ofssl_enabledssl_verify_modein favor ofssl_client_authenticationOther changes
Using
ssl_verify_modeshould keep the current behavior as it is. Once upgraded tossl_client_authentication, it will validate and reject configurations withssl_certificate_authoritiesset andssl_client_authentication = > none. The currentssl_verify_modebehavior is to silently ignore thenonevalue and useforce_peer/required.Fixed
ssl_peer_metadatawhenssl_enabled => false: Standardize SSL settings #470 (comment)Added tests for the new and existing
SslContextBuildermethods.The behavior standardization across plugins, such as the accepted certificate formats, default values, etc will be tackled in future PRs.
Closes elastic/logstash#14925
Closes #399