Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable full-draft mode #587

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Enable full-draft mode #587

merged 1 commit into from
Jul 4, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Jul 4, 2024

  • The user can now create draft data LOCs attached to a draft Identity LOC (i.e. the Identity LOC does not have to be closed anymore).
  • Links can target draft LOCs (i.e. they do not have to be on-chain anymore).
  • Draft request submission is only possible when Identity LOC is closed and all links target closed LOCs.
  • Draft request cancellation is only possible if no incoming links exist and, if an Identity LOC, no other LOCs are attached to it.

logion-network/logion-internal#1318

@gdethier gdethier requested a review from benoitdevos July 4, 2024 09:36
benoitdevos
benoitdevos approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@gdethier gdethier merged commit cf30de7 into main Jul 4, 2024
2 checks passed
@gdethier gdethier deleted the feature/full-draft branch July 4, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos