Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close, transfer, publish, import #536

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Fix close, transfer, publish, import #536

merged 1 commit into from
Nov 24, 2023

Conversation

gdethier
Copy link
Contributor

  • Use submitCall for LOC closing, token transfer, item publication
  • Use submitCallBatch for item import (batch is handled at context level)

logion-network/logion-internal#1081

@gdethier gdethier requested a review from benoitdevos November 24, 2023 13:44
benoitdevos
benoitdevos approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !
2 small remarks that can he handled later on.

src/logion-chain/LogionChainContext.tsx
Comment on lines +152 to +155
state._result = {};
state._error = {};
state._submitted = {};
state._callEnded = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done by the constructor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

src/loc/LocPublishButton.tsx Show resolved Hide resolved
@benoitdevos benoitdevos merged commit 7b453fb into main Nov 24, 2023
2 checks passed
@benoitdevos benoitdevos deleted the feature/use-submit-call-close-transfer-publish-import branch November 24, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos