Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable close with auto-ack #520

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Enable close with auto-ack #520

merged 2 commits into from
Oct 20, 2023

Conversation

gdethier
Copy link
Contributor

  • Adds a toggle next to close button.
  • Toggle is disabled if auto-ack is not possible.
  • Auto-ack is enabled when toggle is turned on.

logion-network/logion-internal#1022

@gdethier gdethier requested a review from benoitdevos October 20, 2023 06:25
benoitdevos
benoitdevos approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !
I have one suggestion, to be discussed:

src/loc/CloseLocButton.tsx Outdated Show resolved Hide resolved
@gdethier gdethier merged commit abfe0ac into main Oct 20, 2023
1 check passed
@gdethier gdethier deleted the feature/batch-close branch October 20, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos