fix: Only error when we verify they're using a disposable domain. #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
cbron
previously approved these changes
Jan 16, 2025
There was a problem hiding this comment.
lgtm, though you should wait for @lizardruss as he would know logging patterns better than I. Debug feels fine since you would almost never want to know or care that this failed. If anything it's a bad thing as it gives a clue to make circumvention easier.
lizardruss
requested changes
Jan 16, 2025
lizardruss
approved these changes
Jan 16, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ignores any errors in trying to get the disposable domains list and only returns an error if the domain being used is found in the list.
I tested this by providing a disposable domain to get the error and by using a list in an invalid json format to get the logging, and see it ignore the error.
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-5542