fix: support separator char in envvar default value #1574
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
force-pushed
the
fix/separator-char-envvar
branch
2 times, most recently
from
e27cf9d to
6ae3b0d
Compare
acolombier
force-pushed
the
fix/separator-char-envvar
branch
from
6ae3b0d to
ae63e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows support for default environment variable containing a
:, used as a sepeartor. A common example for this use case isWithout this fix,
DISPLAYwill be set to an empty string (basically won't be set) if noDISPLAYvariable is defined on the host. With this fix it will default to:0