Skip to content

Commit

Permalink
0.0.3 => 0.0.4
Browse files Browse the repository at this point in the history
  • Loading branch information
lnoss committed Dec 20, 2023
1 parent b117f1b commit f928141
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/submit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Build Firefox extension
run: |
pnpm plasmo build --target=firefox-mv2 --zip
mv build/firefox-mv3-prod.zip firefox-addon-${{ steps.package-version.outputs.current-version }}.zip
mv build/firefox-mv2-prod.zip firefox-addon-${{ steps.package-version.outputs.current-version }}.zip
- name: Build Chrome(-ium) extension
run: |
pnpm plasmo build --target=chrome-mv3 --zip
Expand Down
16 changes: 14 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# Notes

This version is reverting the migration to MV2 for the Firefox extension. 0.0.3 was working fine on Firefox if you manually approve the permissions. Currently, the workflow doesn't auto request approval or denial of the permissions on installation. Some modifications could be done to browsers workflows to request the permissions on installation, but it seems to not be a priority for now. We will see on june.

> As of June 2023, Safari, Firefox, and some Chromium-based browsers don't prompt the user during installation.
> https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissions#requested_permissions_and_user_prompts
The statement seems false, at least Edge is prompting the user for permissions on installation. I don't know if it's a bug or a feature. 😒

# Documentation

- https://bugzilla.mozilla.org/show_bug.cgi?id=1839129

# What changed?
- Migrate to Manifest v3 for the Firefox extension
- Support lazy cleaning of lazy loaded results when scrolling
- Reverting migration to MV3 for the Firefox extension until june 2024 at least (see [#5](https://github.com/lnoss/no-google-search-translation/issues/5))
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "no-google-search-translation",
"displayName": "No Google Search Translation",
"version": "0.0.3",
"version": "0.0.4",
"description": "Disable Google Search results auto translation feature. Auto redirect away from Google Translate proxy to the original URL page.",
"scripts": {
"dev:firefox": "plasmo dev --target=firefox-mv2",
Expand Down

0 comments on commit f928141

Please sign in to comment.