Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resume/reconnection not working! #440

Merged
merged 2 commits into from
Sep 23, 2024
Merged

fix: resume/reconnection not working! #440

merged 2 commits into from
Sep 23, 2024

Conversation

theomonnom
Copy link
Member

  • fix regression due to Update protocol to v15 #394 always disconnecting on signal close
  • now directly trying full_reconnect if the reconnection error isn't a SignalError

@theomonnom theomonnom requested a review from a team September 23, 2024 22:06
davidzhao
davidzhao approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@theomonnom theomonnom merged commit 8fa3011 into main Sep 23, 2024
1 check passed
@theomonnom theomonnom deleted the theo/fix-reconnection branch September 23, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keepingitneil keepingitneil keepingitneil approved these changes

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theomonnom @davidzhao @keepingitneil