Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convenience API for iterating frames from a participant #396

Merged
merged 36 commits into from
Sep 5, 2024
Merged

Convenience API for iterating frames from a participant #396

merged 36 commits into from
Sep 5, 2024

Conversation

keepingitneil
Copy link
Contributor

No description provided.

@keepingitneil keepingitneil marked this pull request as ready for review August 20, 2024 21:49
@keepingitneil keepingitneil requested a review from a team August 20, 2024 21:49
nbsp
nbsp approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a few nits

livekit-ffi/src/server/audio_stream.rs Outdated Show resolved Hide resolved
livekit-ffi/src/server/video_stream.rs Outdated Show resolved Hide resolved
livekit-ffi/src/server/audio_stream.rs Outdated Show resolved Hide resolved
livekit-ffi/src/server/utils.rs Outdated Show resolved Hide resolved
@keepingitneil keepingitneil merged commit 0fe6ae7 into main Sep 5, 2024
4 of 5 checks passed
@keepingitneil keepingitneil deleted the neil/ts branch September 5, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbsp nbsp nbsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepingitneil @nbsp