Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use globally available web crypto API instead of nodeJS crypto module #122

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 8, 2023

closes #121

Also adds multiple test environments for the CI test step (node, browser, edge-runtime)

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: fdc83bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-server-sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome to see this!

@lukasIO lukasIO merged commit 5d41df0 into main Dec 8, 2023
2 checks passed
@lukasIO lukasIO deleted the web-crypto branch December 8, 2023 17:43
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
@Skaldebane
Copy link
Contributor

Skaldebane commented Jan 11, 2024

Great to see this fixed! A workaround that worked for me (before the fix) was adding this to my package.json:

    "browser": {
        "crypto": false
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare Worker support - avoid using 'crypto' from Node
3 participants