Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send JobStatus Updates #998

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Send JobStatus Updates #998

merged 5 commits into from
Nov 5, 2024

Conversation

keepingitneil
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b10538e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@keepingitneil keepingitneil marked this pull request as ready for review October 29, 2024 19:00
@keepingitneil keepingitneil requested a review from a team October 29, 2024 19:00
nbsp
nbsp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weak lgtm, haven't messed with python in a while now but the logic looks great

@keepingitneil keepingitneil merged commit 3b58ee5 into main Nov 5, 2024
8 checks passed
@keepingitneil keepingitneil deleted the neil/ws branch November 5, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbsp nbsp nbsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepingitneil @nbsp