-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pipelineagent: expose timing metrics & api errors wip #957
Conversation
🦋 Changeset detectedLatest commit: 135455e The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if the general design should be more generic.. instead of different events. Imagine the following interface:
pipeline_agent.on('metrics_updated', lambda metrics: print(metrics))
where a single callback would be able to collect all sorts of metrics. we could make the metrics more consistent too:
@dataclass
class AgentMetrics:
type: Literal["tts", "llm",...]
metrics: Union[TTSMetrics, LLMMetrics, STTMetrics, ...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! a few nits.
can we also create an example that shows how one might collect stats? the example could just print them out to console (or perhaps a default console log handler that we can include by default?)
currently: stt, llm, eou, vad, tts timing info