fix Google STT handling of session timeouts #1337
Merged
+95
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also reduces initial retry delay with STT connection errors
🦋 Changeset detectedLatest commit: e973c65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
davidzhao
commented
Jan 6, 2025
jayeshp19
requested changes
Jan 6, 2025
jayeshp19
reviewed
Jan 6, 2025
jayeshp19
approved these changes
Jan 7, 2025
theomonnom
reviewed
Jan 7, 2025
| @@ -44,6 +45,10 @@ | |||
| LgType = Union[SpeechLanguages, str] | |||
| LanguageCode = Union[LgType, List[LgType]] | |||
|
|
|||
| # Google STT has a timeout of 5 mins, we'll attempt to restart the session | |||
| # before that timeout is reached | |||
| _max_session_duration = 4 | |||
There was a problem hiding this comment.
This seems like 4 seconds to me
theomonnom
reviewed
Jan 7, 2025
| time.time() - self._session_connected_at | ||
| > _max_session_duration | ||
| ): | ||
| logger.debug("restarting session due to timeout") |
There was a problem hiding this comment.
Unnecessary log? Should be handled seamlessly IMO
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also reduces initial retry delay with STT/LLM/TTS connection errors
fixes #1258