Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass function context if at max depth #1306

Merged
merged 3 commits into from
Dec 29, 2024

Conversation

martin-purplefish
Copy link
Contributor

As it stands, the agent just stops when it hits the maximum depth - this way it'll be forced to synthesize a reply.

Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: c2698f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@martin-purplefish
Copy link
Contributor Author

PTAL @longcw @davidzhao - I was running into the occasional "max function calls nested depth reached" - I think just not letting it make function calls at max depth is a better user experience? lmk what you think.

@longcw
Copy link
Collaborator

longcw commented Dec 27, 2024

This makes sense to me. I also noticed that when the max depth reached the agent may stop answering even user speech to the agent again, it will reach the max depth quickly again.
But it's better to add a warning there. @davidzhao @theomonnom wdyt?

@davidzhao
Copy link
Member

agreed.. it'd be good to log a warning so users are aware that tools are not being used here. we should prioritize not having the agent being stuck

@martin-purplefish
Copy link
Contributor Author

good call - fixed

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants