-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not pass function context if at max depth #1306
Do not pass function context if at max depth #1306
Conversation
🦋 Changeset detectedLatest commit: c2698f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PTAL @longcw @davidzhao - I was running into the occasional "max function calls nested depth reached" - I think just not letting it make function calls at max depth is a better user experience? lmk what you think. |
This makes sense to me. I also noticed that when the max depth reached the agent may stop answering even user speech to the agent again, it will reach the max depth quickly again. |
agreed.. it'd be good to log a warning so users are aware that tools are not being used here. we should prioritize not having the agent being stuck |
good call - fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
As it stands, the agent just stops when it hits the maximum depth - this way it'll be forced to synthesize a reply.