-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo setup with task runners, testing lib and API consistency tools #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okay, a few nits
also if you could add turbo
to flake.nix nativeBuildInputs
agents/src/index.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed? it's more verbose but i don't know if it helps readability.
either way the REUSE header should be on top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a result of the prettier + eslint config applied and running pnpm format:write
. REUSE header is still on top, I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it got a bit overzealous and put it on top of REUSE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah, now I see it!
also once this is ready please give me time to try and rebase this commit history line into something more parseable |
generally we do squash-merge commits across all repos AFAIK, so this shouldn't be an issue? |
this is a Very big commit to squash, it does a couple of things (parity, testing, turbo, API, general linting). |
yeah, sorry about that. It wasn't planned like that at all. It just suddenly grew out of proportion 😬 |
}, | ||
"peerDependencies": { | ||
"typescript": "^5.0.0" | ||
}, | ||
"dependencies": { | ||
"@livekit/agents": "workspace:*", | ||
"@livekit/elevenlabs": "workspace:*", | ||
"@livekit/agents-plugin-elevenlabs": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for context: the idea behind renaming this was to have a standard way of naming agent plugins in the future, following an example of rollup plugin conventions.
There officially maintained plugins are named @rollup/plugin-official-plugin
and community plugins should be named rollup-plugin-my-plugin
@nbsp do you want to rebase the commits before merging? (I can also do it, just let me know!) |
Co-authored-by: lukasIO <[email protected]>
Co-authored-by: lukasIO <[email protected]>
15f7c74
to
81994b1
Compare
Co-authored-by: lukasIO <[email protected]>
Co-authored-by: lukasIO <[email protected]>
Co-authored-by: lukasIO <[email protected]>
81994b1
to
257b199
Compare
Co-authored-by: lukasIO <[email protected]>
257b199
to
e37a48c
Compare
@lukasIO rebased the whole thing, made sure nothing was lost. let me know if these commits make sense and i'll merge |
looks great, thank you 🙏 |
this adds a couple of things:
TODO: