Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to node:stream/web from homegrown API #194

Draft
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Dec 2, 2024

this PR gets rid of our homegrown AsyncIterableQueue implementation in favour of WHATWG's Streams API.

  • go over plugins
  • implement locking
  • figure out how to check whether a writer is closed

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: ece515b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@livekit/agents Patch
@livekit/agents-plugin-deepgram Patch
@livekit/agents-plugin-elevenlabs Patch
@livekit/agents-plugin-openai Patch
@livekit/agents-plugin-silero Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nbsp nbsp marked this pull request as ready for review December 2, 2024 16:27
@nbsp nbsp marked this pull request as draft December 2, 2024 16:28
@nbsp
Copy link
Member Author

nbsp commented Dec 2, 2024

still doesn't work, there's a rejected promise somewhere

@nbsp nbsp force-pushed the nbsp/chore/streams branch from a6c3ebc to ece515b Compare December 23, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant