Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add changeset release action and initial setup #10

Merged
merged 2 commits into from
May 21, 2024
Merged

Add changeset release action and initial setup #10

merged 2 commits into from
May 21, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented May 21, 2024

No description provided.

@lukasIO lukasIO requested a review from nbsp May 21, 2024 08:03
nbsp
nbsp approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@nbsp nbsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't have access to the internal changeset repo, but otherwise this looks good to me

@nbsp nbsp merged commit 5d4ddb3 into main May 21, 2024
1 check passed
@nbsp nbsp deleted the lukas/changesets branch May 21, 2024 08:22
@nbsp
Copy link
Member

nbsp commented May 21, 2024

@davidzhao need you to add npm registry login to repo secrets for this to work

@lukasIO
Copy link
Contributor Author

lukasIO commented May 21, 2024

I added it in and will re-run the action!

@davidzhao
Copy link
Member

Thanks @lukasIO !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbsp nbsp nbsp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasIO @nbsp @davidzhao