feat(cogify): Update the cogify create cog to support topo raster. BM-1116 #3388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wentao-Kuang
added
container
Wentao-Kuang
added
container
Wentao-Kuang
added
container
Wentao-Kuang
changed the title
blacha
reviewed
Jan 12, 2025
Co-authored-by: Blayne Chard <[email protected]>
blacha
reviewed
Jan 12, 2025
|
|
||
| return { | ||
| command: 'gdal_translate', | ||
| output: targetTiff, | ||
| args: [ | ||
| ['-of', 'COG'], | ||
| cfg.srcwin ? ['-srcwin', cfg.srcwin[0], cfg.srcwin[1], cfg.srcwin[2], cfg.srcwin[3]] : undefined, | ||
| cfg.bigTIFF ? ['-co', `BIGTIFF=${cfg.bigTIFF}`] : ['-co', 'BIGTIFF=IF_NEEDED'], // BigTiff is somewhat slower and most (All?) of the COGS should be well below 4GB |
There was a problem hiding this comment.
why do we need bigtiffs? everything should be well below 4gb?
There was a problem hiding this comment.
We set big tiff as no in the topo-raster, and If_needed for all others atm.
Wentao-Kuang
added
container
Wentao-Kuang
added
container
Wentao-Kuang
added
container
Wentao-Kuang
added
container
| @@ -142,3 +146,45 @@ export function gdalCreate(targetTiff: URL, color: Rgba, opt: CogifyCreationOpti | |||
| .map(String), | |||
| }; | |||
| } | |||
|
|
|||
| export function gdalBuildTopoRasterCommands( | |||
There was a problem hiding this comment.
Suggested change
| export function gdalBuildTopoRasterCommands( | |
| export function gdalBuildTopoCog( |
To mirror the naming convention used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the cogify create cog cli to support for both topo-raster cog and aerial raster cog creation together, so we can use the argo-task topo-stac-creation to prepare the stac files for topo raster map and reuse the create cog cli to do the cog creation.
Modifications
--topoflag for thecreatecommand tag takes the topo50 and topo250 stac files to create topo raster cogs.linz:slugif exists.Verification
Test workflow the topo raster standardised