Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support phpstan 2.0 #635

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Support phpstan 2.0 #635

merged 4 commits into from
Dec 24, 2024

Conversation

eucyt
Copy link
Contributor

@eucyt eucyt commented Dec 24, 2024

I made adjustments due to breaking changes in PHPStan 2.0.
When the Suppress annotation contains a period, quotes are now required.
phpstan/phpdoc-parser#256

close #622

@Yang-33
Copy link
Contributor

Yang-33 commented Dec 24, 2024

doc should be updated(probably)

- name: Update document
run: |
wget https://github.com/phpDocumentor/phpDocumentor/releases/download/v3.3.1/phpDocumentor.phar
php phpDocumentor.phar run -d src -t docs

@Yang-33
Copy link
Contributor

Yang-33 commented Dec 24, 2024

how about showing result of git diff in this step?

diff=$(git --no-pager diff --name-only HEAD)
echo "DIFF_IS_EMPTY=$([[ -z "$diff" ]] && echo 'true' || echo 'false')" >> $GITHUB_ENV
echo "CURRENT_DATETIME=$(date +'%Y%m%d%H%M%S')" >> $GITHUB_ENV
- if: ${{ env.DIFF_IS_EMPTY != 'true' && github.actor != 'renovate[bot]' }}
run: |
echo "There are changes from the auto-generated files by OAS. Please run diff-check.yml and merge the PR generated by it first."
exit 1

@eucyt eucyt requested review from a team and moririnson December 24, 2024 01:57
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@eucyt eucyt merged commit ab04435 into line:master Dec 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants