Merge pull request #7445 from yyforyongyu/fix-heap

discovery: fix heap escape on `cachedMsgs`
lightningnetwork · Feb 24, 2023 · 9f1daf3 · 9f1daf3
2 parents cfc19a9 + ce1d1c6
commit 9f1daf3
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/discovery/gossiper.go b/discovery/gossiper.go
@@ -1905,9 +1905,10 @@ func (d *AuthenticatedGossiper) isPremature(chanID lnwire.ShortChannelID,
 	pMsg := &processedNetworkMsg{msg: copied}
 
 	// Add the network message.
-	cachedMsgs.msgs = append(cachedMsgs.msgs, pMsg)
+	msgs := cachedMsgs.msgs
+	msgs = append(msgs, pMsg)
 	_, err = d.futureMsgs.Put(msgHeight, &cachedNetworkMsg{
-		msgs: cachedMsgs.msgs,
+		msgs: msgs,
 	})
 	if err != nil {
 		log.Errorf("Adding future message got error: %v", err)