-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@clayui/date-picker): update date-fns to v4 #5910
base: master
Are you sure you want to change the base?
Conversation
0a01ac1
to
cdb7533
Compare
cdb7533
to
36c235b
Compare
hmm, there seems to be issues with Jest and ESM, which is the default way date-fns is shipped. Does it make sense to update clay to be pure ESM? |
Thanks Bryce!
@bryceosterhaus I don't see any problem in doing that. |
36c235b
to
9a9642d
Compare
@matuzalemsteles I updated this PR to also include a "dual build" for esm and cjs. I didn't actually test with npm publishing, but just wanted to send it for you to take a look and see. With this change you can probably remove a whole host of babel dependencies |
9a9642d
to
1600cc4
Compare
1600cc4
to
1381ed7
Compare
Thanks @bryceosterhaus. Can I put this on hold for a bit? I'm thinking about putting this on hold for a bit before the PR #5780, it's already in the final stages and I've made a lot of changes... I think this could cause some problems there so I wanted to wait until merged it and work on it. Does that make sense to you? |
Yep! Feel free to put this on hold, I just at least wanted to get something over to you to see and be able to test out. The date-fns update will be merged relatively soon on the portal side, but I believe that should be be fine. |
FYI. I think we are actually just going to remove date-fns in favor of |
We are going to update date-fns to v4 in liferay-portal and realized we should also update it in clay
Let me know if you see any issues with this.