refactor: remove unnecessary object when constructor settingtab

lifeodyssey · Nov 25, 2023 · 4a18425 · 4a18425
1 parent 7f9b2da
commit 4a18425
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -21,7 +21,7 @@ export default class HexoIntegrationPlugin extends Plugin {
 		await this.loadSettings();
 
 		this.symlinkHandler = new SymlinkHandler(this.app);
-		this.addSettingTab(new HexoIntegrationSettingsTab(this.app,this, this.settings, this.symlinkHandler, this.settingsManager));
+		this.addSettingTab(new HexoIntegrationSettingsTab(this.app, this));
 		const hexoBlogPath = this.settings.hexoSourcePath;
 
 		this.gitHandler = new GitHandler(hexoBlogPath);

diff --git a/src/settings/hexoIntegrationSettingsTab.ts b/src/settings/hexoIntegrationSettingsTab.ts
@@ -12,11 +12,8 @@ export default class HexoIntegrationSettingsTab extends PluginSettingTab {
     private symlinkHandler: SymlinkHandler;
     private settingManager:SettingsManager
 
-    constructor(app: App,plugin:HexoIntegrationPlugin, settings: HexoIntegrationSettings, symlinkHandler: SymlinkHandler, settingsManager: SettingsManager) {
+    constructor(app: App,plugin:HexoIntegrationPlugin) {
         super(app,plugin);
-        this.settings = settings;
-        this.symlinkHandler = symlinkHandler;
-        this.settingManager=settingsManager;
     }