-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/automaton deploy script #42
base: main
Are you sure you want to change the base?
Conversation
forking: isForking, | ||
}); | ||
|
||
const govBridgeExecutor = GovBridgeExecutor__factory.connect( | ||
GOV_BRIDGE_EXECUTOR, | ||
optRunner | ||
); | ||
|
||
const networkName = "sepolia"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should 'sepolia' be hardcoded here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this script will be used ever
console.log(`${pad}· l1TokenNonRebasable: ${chalk.underline(params.l1TokenNonRebasable)}`); | ||
console.log(`${pad}· l1RebasableToken: ${chalk.underline(params.l1RebasableToken)}`); | ||
console.log(`${pad}· accountingOracle: ${chalk.underline(params.accountingOracle)}`); | ||
console.log(`${pad}· l2GasLimitForPushingTokenRate: ${chalk.underline(params.l2GasLimitForPushingTokenRate)}`); | ||
console.log(`${pad}· l1TokenBridge: ${chalk.underline(params.l1TokenBridge)}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this and other fields have gone?
@@ -407,7 +412,7 @@ async function printLoadedTestConfig( | |||
console.log( | |||
"In case of unexpected fails, please, make sure that you are forking correct Ethereum/Optimism networks" | |||
); | |||
console.log(` · Network Name: ${networkName}`); | |||
//console.log(` · Network Id: ${networkName}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
WHAT
Changes for automaton script
HOW