Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/automaton deploy script #42

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

kovalgek
Copy link

@kovalgek kovalgek commented Dec 5, 2024

WHAT

Changes for automaton script

HOW

  • use L1 and L2 naming instead of Main, Optimism
  • make hardhat.config flexible for different networks
  • add script for deploying contracts for automaton script
  • refactoring

@kovalgek kovalgek marked this pull request as ready for review January 10, 2025 14:38
@kovalgek kovalgek requested a review from arwer13 January 10, 2025 14:38
scripts/optimism/cross-chain-relayer.ts Show resolved Hide resolved
scripts/optimism/deploy-automaton.ts Outdated Show resolved Hide resolved
forking: isForking,
});

const govBridgeExecutor = GovBridgeExecutor__factory.connect(
GOV_BRIDGE_EXECUTOR,
optRunner
);

const networkName = "sepolia";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 'sepolia' be hardcoded here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this script will be used ever

utils/deployment.ts Outdated Show resolved Hide resolved
console.log(`${pad}· l1TokenNonRebasable: ${chalk.underline(params.l1TokenNonRebasable)}`);
console.log(`${pad}· l1RebasableToken: ${chalk.underline(params.l1RebasableToken)}`);
console.log(`${pad}· accountingOracle: ${chalk.underline(params.accountingOracle)}`);
console.log(`${pad}· l2GasLimitForPushingTokenRate: ${chalk.underline(params.l2GasLimitForPushingTokenRate)}`);
console.log(`${pad}· l1TokenBridge: ${chalk.underline(params.l1TokenBridge)}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this and other fields have gone?

utils/deployment/DeployScript.ts Outdated Show resolved Hide resolved
@@ -407,7 +412,7 @@ async function printLoadedTestConfig(
console.log(
"In case of unexpected fails, please, make sure that you are forking correct Ethereum/Optimism networks"
);
console.log(` · Network Name: ${networkName}`);
//console.log(` · Network Id: ${networkName}`);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

utils/prompt.ts Show resolved Hide resolved
@kovalgek kovalgek requested a review from tamtamchik January 17, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants