Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow aborting authentication #43

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Oct 29, 2024

Allows passing an abort signal to authenticateServer to give the caller control of when to give up waiting for the server response.

Also allows passing a URL as the auth endpoint and allows overriding the hostname/fetch implementations as options instead of requiring them to be passed explicitly.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Allows passing an abort signal to `authenticateServer` to give the
caller control of when to give up waiting for the server response.

Also allows passing a `URL` as the auth endpoint and allows overriding
the hostname/fetch implementations as options instead of requiring
them to be passed explicitly.
@achingbrain achingbrain requested a review from MarcoPolo October 29, 2024 17:50
@MarcoPolo MarcoPolo merged commit 3494773 into main Oct 29, 2024
21 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
## [2.0.2](v2.0.1...v2.0.2) (2024-10-29)

### Bug Fixes

* allow aborting authentication ([#43](#43)) ([3494773](3494773))
Copy link

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants