Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update export paths #42

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix: update export paths #42

merged 4 commits into from
Oct 29, 2024

Conversation

achingbrain
Copy link
Member

Update paths to remove file extensions and use index for default file in directories.

Fixes the following TypeScript error:

Cannot find module '@libp2p/http-fetch/auth.js' or its corresponding type declarations.
  There are types at '/Users/path/to/node_modules/@libp2p/http-fetch/dist/src/auth/auth.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.

We can't update the module resolution yet due to compatibility issues with other dependencies, namely that not all of them have "types" fields in their exports maps yet.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Update paths to remove file extensions and use index for default
file in directories.

Fixes the following TypeScript error:

```
Cannot find module '@libp2p/http-fetch/auth.js' or its corresponding type declarations.
  There are types at '/Users/path/to/node_modules/@libp2p/http-fetch/dist/src/auth/auth.d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'.
```

We can't update the module resolution yet due to compatibility issues
with other dependencies, namely that not all of them have `"types"`
fields in their exports maps yet.
@achingbrain achingbrain merged commit ca914d3 into main Oct 29, 2024
21 checks passed
@achingbrain achingbrain deleted the fix/update-export-paths branch October 29, 2024 11:48
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
## [2.0.1](v2.0.0...v2.0.1) (2024-10-29)

### Bug Fixes

* update export paths ([#42](#42)) ([ca914d3](ca914d3))
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant