Cloudforge review (#56)

* Removed session credentials from toString to prevent secret exposure * Exclude logging libraries to prevent issues with atlassian libs
libertymutual · Nov 6, 2018 · a081886 · a081886
1 parent 663548b
commit a081886
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/pom.xml b/pom.xml
@@ -385,13 +385,11 @@
           </execution>
         </executions>
       </plugin>
-      <!-- Maven Shade Plugin -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-shade-plugin</artifactId>
         <version>3.1.1</version>
         <executions>
-          <!-- Run shade goal on package phase -->
           <execution>
             <phase>package</phase>
             <goals>
@@ -410,6 +408,17 @@
                   </manifestEntries>
                 </transformer>
               </transformers>
+              <artifactSet>
+                <!-- Bringing in additional logging libraries into the atlassian tools can cause adverse effects -->
+                <!-- safeguard for excluding logging libraries-->
+                <excludes>
+                  <exclude>ch.qos.logback:*</exclude>
+                  <exclude>org.apache.logging.log4j:*</exclude>
+                  <exclude>log4j:*</exclude>
+                  <exclude>org.slf4j:*</exclude>
+                  <exclude>commons-logging:*</exclude>
+                </excludes>
+              </artifactSet>
             </configuration>
           </execution>
         </executions>

diff --git a/src/main/java/com/libertymutualgroup/herman/aws/cft/CftPushContext.java b/src/main/java/com/libertymutualgroup/herman/aws/cft/CftPushContext.java
@@ -148,7 +148,6 @@ public String toString() {
             "logger=" + logger +
             ", propertyHandler=" + propertyHandler +
             ", envName='" + envName + '\'' +
-            ", sessionCredentials=" + sessionCredentials +
             ", awsClientConfig=" + awsClientConfig +
             ", region=" + region +
             ", rootPath='" + rootPath + '\'' +

diff --git a/src/main/java/com/libertymutualgroup/herman/aws/ecs/EcsPushContext.java b/src/main/java/com/libertymutualgroup/herman/aws/ecs/EcsPushContext.java
@@ -170,7 +170,6 @@ public String toString() {
             "logger=" + logger +
             ", propertyHandler=" + propertyHandler +
             ", envName='" + envName + '\'' +
-            ", sessionCredentials=" + sessionCredentials +
             ", awsClientConfig=" + awsClientConfig +
             ", region=" + region +
             ", timeout=" + timeout +

diff --git a/src/main/java/com/libertymutualgroup/herman/aws/ecs/broker/s3/S3CreateContext.java b/src/main/java/com/libertymutualgroup/herman/aws/ecs/broker/s3/S3CreateContext.java
@@ -143,7 +143,6 @@ public String toString() {
         return "S3CreateContext{" +
             "logger=" + logger +
             ", propertyHandler=" + propertyHandler +
-            ", sessionCredentials=" + sessionCredentials +
             ", region=" + region +
             ", rootPath='" + rootPath + '\'' +
             ", taskProperties=" + taskProperties +

diff --git a/src/main/java/com/libertymutualgroup/herman/aws/lambda/LambdaPushContext.java b/src/main/java/com/libertymutualgroup/herman/aws/lambda/LambdaPushContext.java
@@ -98,7 +98,6 @@ public LambdaPushContext withTaskProperties(
     @Override
     public String toString() {
         return "LambdaPushContext{" +
-            "sessionCredentials=" + sessionCredentials +
             ", rootPath='" + rootPath + '\'' +
             ", bambooPropertyHandler=" + bambooPropertyHandler +
             ", logger=" + logger +