Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate List.iota #6708

Merged
merged 2 commits into from
Jan 21, 2025
Merged

chore: deprecate List.iota #6708

merged 2 commits into from
Jan 21, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jan 20, 2025 •
edited
Loading

This PR deprecates List.iota, which we make no essential use of. iota n can be replaced with (range' 1 n).reverse. The verification lemmas for range' already have better coverage than those for iota.
Any downstream projects using it (I am not aware of any) are encouraged to adopt it.

@kim-em kim-em added the changelog-library Library label Jan 20, 2025
@kim-em kim-em requested a review from Kha as a code owner January 20, 2025 04:31
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 20, 2025 04:45 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 20, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 20, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e40e0892c1aba8e2ca0a1bfb648c9a5fe4b2fe2f --onto 74bd40d34d1a969da65007939960c2fefd461f08. (2025-01-20 04:56:13)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e40e0892c1aba8e2ca0a1bfb648c9a5fe4b2fe2f --onto ac6a29ee834ba7fd30e9372e51493d7741e9c657. (2025-01-21 02:34:54)

@kim-em
Copy link
Collaborator Author

kim-em commented Jan 21, 2025

(Markus' emoji above is sadness at losing the APL-esque name, not about losing the function.)

@kim-em kim-em enabled auto-merge January 21, 2025 02:17
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 21, 2025 02:24 Inactive
@kim-em kim-em added this pull request to the merge queue Jan 21, 2025
Merged via the queue into master with commit 16bd7ea Jan 21, 2025
15 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@kim-em @luisacicolini
chore: deprecate List.iota (leanprover#6708)
05b64be 
This PR deprecates `List.iota`, which we make no essential use of. `iota
n` can be replaced with `(range' 1 n).reverse`. The verification lemmas
for `range'` already have better coverage than those for `iota`.
Any downstream projects using it (I am not aware of any) are encouraged
to adopt it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Awaiting requested review from Kha Kha is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot