Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: complete alignment of {List,Array,Vector}.{mapIdx,mapFinIdx} #6701

Merged
merged 10 commits into from
Jan 20, 2025
Merged

feat: complete alignment of {List,Array,Vector}.{mapIdx,mapFinIdx} #6701

merged 10 commits into from
Jan 20, 2025

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Jan 20, 2025

This PR completes aligning mapIdx and mapFinIdx across List/Array/Vector.

@kim-em kim-em added the changelog-library Library label Jan 20, 2025
@kim-em kim-em requested a review from digama0 as a code owner January 20, 2025 00:03
@kim-em kim-em enabled auto-merge January 20, 2025 00:04
@kim-em kim-em changed the title feat: complete alignment of {List,Array,Vector}.{mapIdx,mapFinIdx}. feat: complete alignment of {List,Array,Vector}.{mapIdx,mapFinIdx} Jan 20, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 20, 2025 04:02 Inactive
@kim-em kim-em added this pull request to the merge queue Jan 20, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 20, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase a062eea204a9c982e318c0c98cd6af63e9f61050 --onto 74bd40d34d1a969da65007939960c2fefd461f08. (2025-01-20 04:09:06)

Merged via the queue into master with commit ac6a29e Jan 20, 2025
15 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@kim-em @luisacicolini
feat: complete alignment of {List,Array,Vector}.{mapIdx,mapFinIdx} (l…
9004e6c 
…eanprover#6701)

This PR completes aligning `mapIdx` and `mapFinIdx` across
`List/Array/Vector`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot