Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_udiv] #6674

Merged
merged 8 commits into from
Jan 21, 2025
Merged

feat: add BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_udiv] #6674

merged 8 commits into from
Jan 21, 2025

Conversation

luisacicolini
Copy link
Contributor

@luisacicolini luisacicolini commented Jan 16, 2025 •
edited
Loading

This PR adds theorems BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_udiv]

@luisacicolini luisacicolini requested a review from kim-em as a code owner January 16, 2025 22:36
@luisacicolini
Copy link
Contributor Author

changelog-library

@github-actions github-actions bot added the changelog-library Library label Jan 16, 2025
@luisacicolini luisacicolini changed the title feat: add BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_udiv ] feat: add BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_udiv] Jan 16, 2025
@luisacicolini
Copy link
Contributor Author

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Jan 16, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 16, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e42f7d9fc30cbbb9187718c40bdba91447385b92 --onto f4c9934171a22d376fb7c318ce2dcf80ab0eaf0e. (2025-01-16 23:03:30)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase e42f7d9fc30cbbb9187718c40bdba91447385b92 --onto 74bd40d34d1a969da65007939960c2fefd461f08. (2025-01-20 11:23:40)

bollu
bollu reviewed Jan 17, 2025
View reviewed changes
src/Init/Data/BitVec/Bitblast.lean Outdated Show resolved Hide resolved
src/Init/Data/BitVec/Bitblast.lean Show resolved Hide resolved
src/Init/Data/BitVec/Bitblast.lean Outdated Show resolved Hide resolved
@kim-em kim-em added this pull request to the merge queue Jan 21, 2025
@kim-em kim-em removed the awaiting-review Waiting for someone to review the PR label Jan 21, 2025
Merged via the queue into leanprover:master with commit f9e904a Jan 21, 2025
15 checks passed
luisacicolini added a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@luisacicolini @bollu
feat: add `BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv, getMsbD_u…
8f98fee 
…div]` (leanprover#6674)

This PR adds theorems `BitVec.[getMsbD_mul, getElem_udiv, getLsbD_udiv,
getMsbD_udiv]`

---------

Co-authored-by: Siddharth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bollu bollu bollu left review comments

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisacicolini @leanprover-community-bot @bollu @kim-em