Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve E-matching pattern selection heuristics #6653

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: improve E-matching pattern selection heuristics #6653

merged 1 commit into from
Jan 15, 2025

Conversation

leodemoura
Copy link
Member

This PR improves the E-matching pattern selection heuristics in the grind tactic. They now take into account type predicates and transformers.

@leodemoura
fix: improve E-matching pattern selection heuristics
f7bc692 
This PR improves the E-matching pattern selection heuristics in the
`grind` tactic. They now take into account type predicates and transformers.
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 15, 2025
@leodemoura leodemoura enabled auto-merge January 15, 2025 16:27
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 15, 2025 16:39 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 15, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 15, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 6665837232cc8464eb2d41534ce7e50db6fda674 --onto a955708b6c5f25e7f9c9ae7b951f8f3d5aefe377. (2025-01-15 16:48:58)

Merged via the queue into master with commit b3f8fef Jan 15, 2025
18 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@leodemoura @luisacicolini
fix: improve E-matching pattern selection heuristics (leanprover#6653)
c9d4292 
This PR improves the E-matching pattern selection heuristics in the
`grind` tactic. They now take into account type predicates and
transformers.
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@leodemoura @JovanGerb
fix: improve E-matching pattern selection heuristics (leanprover#6653)
af57fbd 
This PR improves the E-matching pattern selection heuristics in the
`grind` tactic. They now take into account type predicates and
transformers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot