Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Windows stage0 linking #6622

Merged
merged 8 commits into from
Jan 14, 2025
Merged

fix: Windows stage0 linking #6622

merged 8 commits into from
Jan 14, 2025

Conversation

hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Jan 13, 2025 •
edited
Loading

This PR fixes stage0 linking on Windows against winsock.

@hargoniX hargoniX added release-ci Enable all CI checks for a PR, like is done for releases changelog-no Do not include this PR in the release changelog labels Jan 13, 2025
@hargoniX hargoniX requested a review from Kha January 13, 2025 09:13
@github-actions github-actions bot added the changes-stage0 Contains stage0 changes, merge manually using rebase label Jan 13, 2025
TwoFX
TwoFX reviewed Jan 13, 2025
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 13, 2025 09:27 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 13, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2421f7f79941853da14346a234aec6df70cf36a1 --onto d2c4471cfa4611977bf4927b5cd849df1a4272b7. (2025-01-13 10:44:27)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 13, 2025 15:35 Inactive
@hargoniX hargoniX requested a review from kim-em as a code owner January 13, 2025 20:38
@hargoniX hargoniX removed the request for review from kim-em January 13, 2025 20:38
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 13, 2025 20:43 Inactive
@hargoniX hargoniX force-pushed the hbv/fix-winsock-stage0 branch from 7cce3b6 to cf0516f Compare January 13, 2025 21:08
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 13, 2025 21:43 Inactive
@hargoniX hargoniX force-pushed the hbv/fix-winsock-stage0 branch from 9d0037f to 0f22591 Compare January 13, 2025 22:55
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 13, 2025 23:01 Inactive
@Kha Kha merged commit e9bd980 into master Jan 14, 2025
22 checks passed
@hargoniX hargoniX deleted the hbv/fix-winsock-stage0 branch January 14, 2025 08:25
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@hargoniX @Kha @luisacicolini
fix: Windows stage0 linking (leanprover#6622)
916a617 
This PR fixes stage0 linking on Windows against winsock.

---------

Co-authored-by: Sebastian Ullrich <[email protected]>
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@hargoniX @Kha @JovanGerb
fix: Windows stage0 linking (leanprover#6622)
ca4f2a3 
This PR fixes stage0 linking on Windows against winsock.

---------

Co-authored-by: Sebastian Ullrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX left review comments

@Kha Kha Awaiting requested review from Kha

Assignees
No one assigned
Labels
changelog-no Do not include this PR in the release changelog changes-stage0 Contains stage0 changes, merge manually using rebase release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hargoniX @leanprover-community-bot @TwoFX @Kha