refactor: lake: use StateRefT for BuildStore
#6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
!bench |
|
Here are the benchmark results for commit 79d8c56. |
tydeu
force-pushed
the
lake/ref-build-store
branch
from
79d8c56 to
66d2c0b
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jan 15, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jan 15, 2025
leanprover-community-bot
added
the
builds-mathlib
|
!bench |
|
Here are the benchmark results for commit 66d2c0b. |
|
!bench |
|
Here are the benchmark results for commit 66d2c0b. |
|
Here are the benchmark results for commit 66d2c0b. |
|
Here are the benchmark results for commit 66d2c0b. |
|
!bench |
|
Here are the benchmark results for commit 66d2c0b. |
|
Here are the benchmark results for commit 66d2c0b. |
|
Here are the benchmark results for commit 66d2c0b. Benchmark Metric Change
===================================================
+ big_do task-clock -3.0% (-12.9 σ)
+ big_do wall-clock -3.0% (-12.6 σ)
+ liasolver task-clock -2.8% (-21.2 σ)
+ liasolver wall-clock -2.9% (-12.9 σ)
+ rbmap_1 task-clock -4.3% (-13.4 σ)
+ rbmap_1 wall-clock -4.3% (-13.5 σ)
- stdlib instantiate metavars 4.8% (30.4 σ) |
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Jan 21, 2025
This PR uses `StateRefT` instead of `StateT` to equip the Lake build monad with a build store. As a IO reference, different threads may now contend with the build store. However, benchmark results indicate that this does not have a significant performance impact. On a synchronization front, the lack of a mutex should not be a concern because the build store is a memorization data structure and thus order is theoretically irrelevant.
JovanGerb
pushed a commit
to JovanGerb/lean4
that referenced
this pull request
Jan 21, 2025
This PR uses `StateRefT` instead of `StateT` to equip the Lake build monad with a build store. As a IO reference, different threads may now contend with the build store. However, benchmark results indicate that this does not have a significant performance impact. On a synchronization front, the lack of a mutex should not be a concern because the build store is a memorization data structure and thus order is theoretically irrelevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
StateRefTinstead ofStateTto equip the Lake build monad with a build store.As a IO reference, different threads may now contend with the build store. However, benchmark results indicate that this does not have a significant performance impact. On a synchronization front, the lack of a mutex should not be a concern because the build store is a memorization data structure and thus order is theoretically irrelevant.